feat(vm): add target migration #1874
Open
+509
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
feat/vm/add-target-migration
branch
5 times, most recently
from
d3b8f62 to
8d9134f
Compare
added 10 commits
January 19, 2026 19:42
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
feat/vm/add-target-migration
branch
from
065512f to
cca7297
Compare
hardcoretime
requested review from
Isteb4k,
fl64,
goganat,
yaroslavborbat and
z9r5
as code owners
z9r5
approved these changes
Jan 20, 2026
yaroslavborbat
requested changes
Jan 20, 2026
images/virtualization-artifact/pkg/controller/vmop/migration/internal/service/migration.go
Show resolved
Hide resolved
yaroslavborbat
requested changes
Jan 20, 2026
Comment on lines
+51
to
+57
|
|
||
| func (n *nodeSelectorValidator) validateNodeSelector(nodeSelector map[string]string) error { | ||
| for k, v := range nodeSelector { | ||
| if errs := validation.IsQualifiedName(k); len(errs) != 0 { | ||
| return fmt.Errorf("invalid label key: %v", errs) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Fail fast if the user's input is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A virtual machine can now be migrated to a particular node using the NodeSelector option in the virtual machine operation.
Why do we need it, and what problem does it solve?
This is required to enhance the user experience with virtual machine migration.
What is the expected result?
A virtual machine can be migrated to a particular node using defined labels.
Checklist
Changelog entries