fix(vm): migration condition clearing #1891
Open
+10
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilrwx
force-pushed
the
fix/vm/migration-condition-clearing
branch
2 times, most recently
from
08b25f6 to
3dfa74c
Compare
Signed-off-by: Daniil Antoshin <[email protected]> remove unused Signed-off-by: Daniil Antoshin <[email protected]> remove Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
force-pushed
the
fix/vm/migration-condition-clearing
branch
from
70dd645 to
4b71acb
Compare
Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
requested review from
Isteb4k,
fl64 and
yaroslavborbat
as code owners
Contributor
|
Workflow has started. The target step completed with status: failure. |
yaroslavborbat
approved these changes
Jan 20, 2026
Contributor
|
Workflow has started. The target step completed with status: failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the logic for clearing the
Migratingcondition in theMigratingHandler. The changes ensure that the condition is properly removed when migrations are completed, failed, or not requested, and improve the handling of migration state synchronization.Why do we need it, and what problem does it solve?
Previously, the
Migratingcondition could remain in the VM status even after migrations were completed or failed, leading to:What is the expected result?
When migration completes successfully: The
Migratingcondition is removed from the VM status whenVMOPreachesReasonOperationCompletedorVMOPPhaseCompleted.When migration fails: The
Migratingcondition is removed whenVMOPreachesVMOPPhaseFailedphase, ensuring failed migrations don't leave stale conditions.When VM is stopped (KVVMI is nil): The
Migratingcondition is removed since live migration cannot occur without a running VM instance.When migration operation is terminating: The condition is removed when
VMOPentersVMOPPhaseTerminatingphase.When no migration is requested: The condition is removed if there's no active migration operation.
Checklist
Changelog entries