Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [FROMLIST] dmaengine: qcom: gpi: set DMA_PRIVATE capability#1808

Open
Avenger-285714 wants to merge 1 commit into
deepin-community:linux-6.6.yfrom
Avenger-285714:qcomgpi-6.6
Open

[Deepin-Kernel-SIG] [linux 6.6.y] [FROMLIST] dmaengine: qcom: gpi: set DMA_PRIVATE capability#1808
Avenger-285714 wants to merge 1 commit into
deepin-community:linux-6.6.yfrom
Avenger-285714:qcomgpi-6.6

Conversation

@Avenger-285714
Copy link
Copy Markdown
Member

@Avenger-285714 Avenger-285714 commented Jun 3, 2026

The GPI DMA controller is only responsible for QUP peripherals, and cannot work as a general-purpose DMA accelerator.

Set DMA_PRIVATE capability for it.

This fixes error messages about GPI being shown when an async-tx consumer is loaded.

Fixes: 5d0c353 ("dmaengine: qcom: Add GPI dma driver")

Link: https://lore.kernel.org/all/20260602070344.3707256-1-zhengxingda@iscas.ac.cn/
Suggested-by: Icenowy Zheng zhengxingda@iscas.ac.cn

Summary by Sourcery

Bug Fixes:

  • Prevent spurious async-tx error messages by setting the DMA_PRIVATE capability on the Qualcomm GPI DMA controller.

The GPI DMA controller is only responsible for QUP peripherals, and
cannot work as a general-purpose DMA accelerator.

Set DMA_PRIVATE capability for it.

This fixes error messages about GPI being shown when an async-tx
consumer is loaded.

Fixes: 5d0c353 ("dmaengine: qcom: Add GPI dma driver")
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Link: https://lore.kernel.org/all/20260602070344.3707256-1-zhengxingda@iscas.ac.cn/
Suggested-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Signed-off-by: WangYuli <wangyl5933@chinaunicom.cn>
@Avenger-285714 Avenger-285714 requested review from Copilot and opsiff June 3, 2026 07:16
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Qualcomm GPI DMA engine driver to mark it as a private DMA controller, restricting its use to QUP peripherals and preventing it from being treated as a general-purpose async-tx DMA provider.

File-Level Changes

Change Details Files
Mark the Qualcomm GPI DMA engine as a private DMA controller by enabling the DMA_PRIVATE capability in its probe routine.
  • Extend the GPI DMA device capability mask initialization to include DMA_PRIVATE alongside DMA_SLAVE so the controller is only used by its dedicated clients
  • Rely on the updated capability mask to avoid GPI being offered to generic async-tx consumers, eliminating spurious error messages when such consumers are loaded
drivers/dma/qcom/gpi.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot requested a review from huangbibo June 3, 2026 07:16
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Marks the Qualcomm GPI DMAengine device as private so it won’t be considered by the generic async-tx DMA allocator/channel table, avoiding misleading “no DMA channels” style messages when unrelated async-tx consumers load. This aligns with GPI’s role as a QUP-peripheral-specific DMA controller rather than a general-purpose DMA engine.

Changes:

  • Set the DMA_PRIVATE capability on the GPI DMA device during probe to keep it out of the general-purpose DMA allocation paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants