[AMD] Skipped amp testcases for ROCm #7745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestAmp failures observed on ROCm due to: deepspeedai@53e91a0#diff-e6635a81d2c2bf0938b5f83b1c4945e0f344e0106191a6960df8ee4aa64cc55fR2305 Since amp is deprecated and removed from apex (NVIDIA/apex#1896), and these tests are already skipped on NVIDIA, we will skip them on ROCm as well. Signed-off-by: Artem Kuzmitckii <[email protected]>
| _amp_available = False | ||
|
|
||
| # amp is likely to be deprecated in the future (see https://github.com/NVIDIA/apex/pull/1896). | ||
| # For now, we are skipping TestAmp to avoid failures on the ROCm platform caused by |
Collaborator
There was a problem hiding this comment.
Can you help disable for all platforms?
Contributor
Author
There was a problem hiding this comment.
@sfc-gh-truwase whats about removing whole TestAmp(amp removed from apex NVIDIA/apex#1896)?
Collaborator
There was a problem hiding this comment.
Yes, that works. Thanks!
sfc-gh-truwase
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAmp failures observed on ROCm due to:
53e91a0#diff-e6635a81d2c2bf0938b5f83b1c4945e0f344e0106191a6960df8ee4aa64cc55fR2305, but since amp is deprecated and removed from apex (NVIDIA/apex#1896), and these tests are already skipped on NVIDIA, we will skip them on ROCm as well.
Command for verification:
pytest -v tests/unit/runtime/half_precision/test_fp16.py -k 'TestAmp'