Allow overrides to fillFaceboxFrom* behavior via $.facebox.fillFrom*#28
Open
Empact wants to merge 2 commits intodefunkt:masterfrom
Open
Allow overrides to fillFaceboxFrom* behavior via $.facebox.fillFrom*#28Empact wants to merge 2 commits intodefunkt:masterfrom
Empact wants to merge 2 commits intodefunkt:masterfrom
Conversation
…om* functions onto the $.facebox object as $.facebox.fillFrom*. E.g., you can now override $.facebox.fillFrom* to customize your AJAX calls. Previously private function which are now available on $.facebox: init, fillFromAjax, fillFromImage, fillFromHref Previously private functions which remain private: As inner functions: showOverlay, getPageHeight, getPageScroll, makeCompatible As local to the closure: hideOverlay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve customizability by moving the private fillFaceboxFrom* functions onto the$.facebox object as $ .facebox.fillFrom*. E.g., you can now override $.facebox.fillFromAjax to customize your AJAX calls.
Previously private function which are now available on $.facebox: init, fillFromAjax, fillFromImage, fillFromHref
Previously private functions which remain private:
As inner functions: showOverlay, getPageHeight, getPageScroll, makeCompatible
As local to the closure: hideOverlay
In $.facebox, I pass the full first data argument to the fillFrom* functions, to allow people to use and process additional arguments on the call side as well.
This addresses pull request #26 and #11 by given people the hooks they need to customize behavior to suit their apps.