Update AV1013: Don't cast a base class to one of its derived classes#349
Open
dennisdoomen wants to merge 1 commit intodevelopfrom
Open
Update AV1013: Don't cast a base class to one of its derived classes#349dennisdoomen wants to merge 1 commit intodevelopfrom
dennisdoomen wants to merge 1 commit intodevelopfrom
Conversation
Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkoelman
reviewed
Mar 29, 2026
| Having dependencies from a base class to its sub-classes goes against proper object-oriented design and might prevent other developers from adding new derived classes. | ||
| Having dependencies from a base class to its derived classes goes against proper object-oriented design and might prevent other developers from adding new derived classes. | ||
|
|
||
| // Wrong |
Collaborator
There was a problem hiding this comment.
This example is about something else entirely. It has no base class that references derived classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates guideline AV1013.
It was split out of #298 so the change can be reviewed independently.
Files:
Part of the replacement for #298.