Update AV1545: Don't use an if-else construct instead of a simple (conditional) assignment#364
Open
dennisdoomen wants to merge 1 commit intodevelopfrom
Open
Update AV1545: Don't use an if-else construct instead of a simple (conditional) assignment#364dennisdoomen wants to merge 1 commit intodevelopfrom
if-else construct instead of a simple (conditional) assignment#364dennisdoomen wants to merge 1 commit intodevelopfrom
Conversation
Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkoelman
reviewed
Mar 29, 2026
| title: Don't use an `if`-`else` construct instead of a simple (conditional) assignment | ||
| severity: 2 | ||
| --- | ||
| Express your intentions directly. For example, rather than: |
Collaborator
There was a problem hiding this comment.
Suggested change
| Write conditional expressions using modern, concise syntax. For example, rather than: |
| --- | ||
| rule_id: 1545 | ||
| rule_category: maintainability | ||
| title: Don't use an `if`-`else` construct instead of a simple (conditional) assignment |
Collaborator
There was a problem hiding this comment.
Suggested change
| title: Use concise conditional expressions instead of `if`-`else` blocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates guideline AV1545.
It was split out of #298 so the change can be reviewed independently.
Files:
Part of the replacement for #298.