fix: stop rewriting the window global - #516
Merged
Merged
Conversation
`window` was being rewritten to `globalThis` (or `dntShim.dntGlobalThis` when the shim proxy was used), which broke browser detection because `typeof window === "object"` would then always be true. `window` doesn't exist in Deno anymore, so leave it alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnt was rewriting any unresolved
windowidentifier toglobalThis, or todntShim.dntGlobalThiswhen the global shim proxy was in play. That breaks browser detection:typeof window === "object"came out astypeof dntShim.dntGlobalThis === "object", which is always true.windowno longer exists in Deno, so there's nothing to transform — it's now left completely alone.globalThishandling is unchanged, and thedntGlobalThismerge proxy never definedwindow.Closes the
windowpart of #454 (see #454 (comment)).