feat: add a cwd build option - #518
Merged
Merged
Conversation
So that every call site is explicit about the directory it resolves a relative path from, leaving `Deno.cwd()` only where it's the answer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
cwdbuild option so that dnt can operate on a directory other than the process's current working directory:It defaults to
Deno.cwd(), so existing builds are unaffected.There were three separate places relying on the process cwd:
standardizePathresolvedentryPoints,outDir, andtestPreloadModuleagainst it.rootTestDir ?? Deno.cwd()as its root (this is what causes an unrelated subdirectory of the cwd to get pulled into a build).All three now resolve from the
cwdoption. Along the way:transform()API now resolves its own relative paths (entry points, mappings,importMap,configFile, module shims) from its existingcwdoption instead of the process cwd, and accepts a plain path there in addition to a file url.rootTestDirwas previously handed toexpandGlobunresolved, so a relative value resolved against the process cwd. It now resolves from thecwdoption.mapMappingKey'sexistsSync(key)fallback was probing the process cwd.Closes #337