feat: pass filename and tree path to detective#111
Draft
AndersDJohnson wants to merge 2 commits intodependents:mainfrom
Draft
feat: pass filename and tree path to detective#111AndersDJohnson wants to merge 2 commits intodependents:mainfrom
AndersDJohnson wants to merge 2 commits intodependents:mainfrom
Conversation
AndersDJohnson
changed the title
This was referenced Jul 16, 2022
Closed
AndersDJohnson
force-pushed
the
detective-filename
branch
from
72b1ac1 to
6e674f1
Compare
AndersDJohnson
commented
Aug 28, 2022
test/index.js
Outdated
| }); | ||
|
|
||
| assert.deepEqual(stub.args[0][1], config.amd); | ||
| assert.deepEqual(stub.args[0][1].skipLazyLoaded, config.amd.skipLazyLoaded); |
Author
There was a problem hiding this comment.
Modifying these two tests to assert only on the specific property they're setting up, rather than the whole arguments objects, which now include more data irrelevant to this test, including filename.
Member
|
@AndersDJohnson please rebase and add a separate test. |
XhmikosR
force-pushed
the
detective-filename
branch
from
435b18d to
a374aa9
Compare
Member
|
@AndersDJohnson I rebased your branch; now we only need the tests fixed and new ones added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports dependents/node-dependency-tree#147.
filenameis existing, buttreePathwill only come with dependents/node-dependency-tree#149.See example use case in dependents/detective-typescript#48.