Partitioned processing#15
Draft
sharkinsspatial wants to merge 22 commits into
Draft
Conversation
Design for a local pytest spike that de-risks the core fork/merge mechanics from issue #12 before building Step Functions infrastructure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
All forks must descend from the single session that performs the merge, so the coordinator owns fork creation and the merge. Removes the independently-created-fork hypothesis and fallback framing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Scratch verification while preparing the plan showed merge silently last-writer-wins on overlapping chunk keys (conflict detection is a rebase-against-branch-tip concern, not a sibling-fork-merge one). Fix assertion #4 to a characterization test, record confirmed findings, and capture the verified zarr array-creation mechanism. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pre-commit mypy hook runs in an isolated env without icechunk, so commit() resolves to Any there and warn_return_any flags a bare return. Add a comment so the cast is not mistakenly removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Also record the storage finding in the spec: backfill requires durable (filesystem/S3) storage because a pickled ForkSession cannot resolve its base snapshot from in-memory storage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address A-Task 2 code-review minors: document the not-idempotent constraint in the Protocol docstring and assert chunk/dtype so a geometry regression is caught before the Task 3 round-trip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Address A-Task 3 code-review minor: create_fork now uses keyword-only branch, matching merge_and_commit and promote, before sub-project B consumers are written against the API. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address final-review minors for sub-project A: the region_for Protocol docstring now signals that the file_key scheme is implementation-defined, and process_backfill_file explains why it catches broad exceptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.