Skip to content

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 19, 2025

What does this PR do?

Enhance the backup cronjob controller to track backup status individually for each workspace using annotations. This allows more granular control over when backups are triggered based on each workspace's specific backup history rather than a global timestamp.

  • Add handleBackupJobStatus to update DevWorkspace annotations when backup jobs complete or fail
  • Modify wasStoppedSinceLastBackup to check workspace-specific annotations first, falling back to global time
  • Include DevWorkspace name label on backup jobs for easier association

Assisted-by: Claude

What issues does this PR fix or reference?

#1549

Is it tested? How?

TODO

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants