Skip to content

compiler: Improve scalar aliases detection and scheduling#2858

Open
mloubout wants to merge 2 commits intomainfrom
alias-multi-cond
Open

compiler: Improve scalar aliases detection and scheduling#2858
mloubout wants to merge 2 commits intomainfrom
alias-multi-cond

Conversation

@mloubout
Copy link
Contributor

@mloubout mloubout commented Feb 25, 2026

Quite a few more changes that I would have liked but this avoid being too drastic. This basically make scalar aliases more reobust

  • Remove guards from scalar aliases used in multiple clusters to avoid issue with scope of variable
  • No longer allow scalar aliases that depend on a condition
  • Make aliases const (tiny change but bit better technically)
  • Small fix on lifting that prevents detaching scalar clusters from cluster with same guard
  • Tiny change to cse dtype due to numpy integer upcasting

@mloubout mloubout force-pushed the alias-multi-cond branch 2 times, most recently from 19254fd to 6af1a6b Compare February 25, 2026 16:21
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloubout mloubout changed the title compiler: prevent undefined Temp through global init compiler: Prevent undefined Temp through global init Feb 25, 2026
@mloubout mloubout force-pushed the alias-multi-cond branch 3 times, most recently from e2045e5 to b859dc4 Compare February 25, 2026 17:02
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.00%. Comparing base (8ad5ec1) to head (1a3141e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
+ Coverage   78.96%   79.00%   +0.03%     
==========================================
  Files         248      248              
  Lines       51089    51167      +78     
  Branches     4422     4427       +5     
==========================================
+ Hits        40344    40422      +78     
+ Misses       9937     9935       -2     
- Partials      808      810       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout mloubout force-pushed the alias-multi-cond branch 3 times, most recently from 10bd3a7 to 169301f Compare February 25, 2026 19:17
@mloubout mloubout force-pushed the alias-multi-cond branch 7 times, most recently from 7fa5e9a to 8c0a82b Compare February 26, 2026 17:19
@mloubout mloubout changed the title compiler: Prevent undefined Temp through global init compiler: Improve scalar aliases detection and scheduling Feb 26, 2026
@mloubout mloubout force-pushed the alias-multi-cond branch 2 times, most recently from 4574945 to 42387e7 Compare February 26, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant