Skip to content

#1552: add certificates to truststore#1789

Merged
hohwille merged 32 commits intodevonfw:mainfrom
MarvMa:feature/#1552-add-certificates-to-truststore
Apr 7, 2026
Merged

#1552: add certificates to truststore#1789
hohwille merged 32 commits intodevonfw:mainfrom
MarvMa:feature/#1552-add-certificates-to-truststore

Conversation

@MarvMa
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa commented Mar 30, 2026 •
edited
Loading

This PR fixes #1552

Implemented changes:

  • Added a new TruststoreCommandlet which is accessible via ide fix-tls-vpn-problem <url> command.
  • Added a TruststoreUtil
    • Create or update a custom Truststore
    • Copy existing certificates from cacerts to custom truststore
    • Add a Certificate to the custom Truststore

The functionality has been tested on Windows 11 and WSL Debian.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

MarvMa and others added 21 commits March 13, 2026 16:30
@MarvMa
devonfw#1750: added Updater for golang support
5b8f1d5
@MarvMa
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
a13c169 
…evonfw#1750-gourlupdater
@MarvMa
devonfw#1751: create Go commandlet
4f72ebe
@MarvMa
devonfw#1751: remove wrongly committed files
16b6a0e
@MarvMa
devonfw#1751: added Go tag, fixed naming and added go to the commandl…
e2da970 
…etManger
@MarvMa
devonfw#1751: added tool installation for go
2e39d2f
@MarvMa
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
4945197 
…evonfw#1751-create-go-commandlet
@MarvMa
devonfw#1751: implemented go installation
0fe2b3d
@MarvMa
devonfw#1751: updated implementation of go installation, added tests …
4a4f561 
…and doc for go
@MarvMa
devonfw#1751: added go-lang support for cli to changelog
e20a599
@MarvMa
devonfw#1687: added argument to suppress native warning
10f9880
@MarvMa
merge
92b1726
@hohwille
Merge branch 'main' into feature/devonfw#1687-fix-JLine-warning
dd0067a
@MarvMa
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
0905a1f 
…evonfw#1687-fix-JLine-warning
@MarvMa
devonfw#1687: updated changelog
189ed57
@MarvMa
devonfw#1552: integrated a truststore commandlet to create a custom t…
5779788 
…ruststore
@MarvMa
devonfw#1552: integrated a truststore commandlet to create a custom t…
a4d5fdc 
…ruststore
@MarvMa
devonfw#1552: added tests, description for the commandlet and remove …
3736c9c 
…changable password for the custom truststore
@MarvMa
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
e63fc70 
…evonfw#1552-add-certificates-to-truststore
@MarvMa
devonfw#1552: added tests for truststore cmdlet
61b29a8
@MarvMa
devonfw#1552: update changelog
22b773a
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Mar 30, 2026
@MarvMa MarvMa added enhancement New feature or request download download of tools, plugins, code from git, any HTTP traffic over the network labels Mar 30, 2026
@MarvMa MarvMa marked this pull request as ready for review March 30, 2026 11:27
@MarvMa MarvMa moved this from 🆕 New to Team Review in IDEasy board Mar 30, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 30, 2026 •
edited
Loading

Coverage Report for CI Build 24082290380

Coverage decreased (-0.2%) to 70.47%

Details

  • Coverage decreased (-0.2%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 20 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

20 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/network/NetworkStatusImpl.java 11 68.04%
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 8 90.16%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 15066
Covered Lines: 11068
Line Coverage: 73.46%
Relevant Branches: 6688
Covered Branches: 4262
Branch Coverage: 63.73%
Branches in Coverage %: Yes
Coverage Strength: 3.1 hits per line
💛 - Coveralls

hohwille
hohwille approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for your PR. Excellent work! You really solved this complex problem nicely 🥇
It seems that some information was lost in the hand-over that I gave in earlier briefings and meetings to @lubska but I left review comments for that.

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Mar 30, 2026
@MarvMa MarvMa requested a review from ducminh02 March 31, 2026 13:18
hohwille
hohwille approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for the update. Very nice improvements. 👍
We are on the finishing line but before we can merge there are some few points to address.

@MarvMa MarvMa moved this from 👀 In review to Team Review in IDEasy board Apr 2, 2026
hohwille
hohwille approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for finishing this PR. Seems fully functional now. 👍
Left a small change that we can immediately apply/commit.

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Apr 7, 2026
MarvMa and others added 2 commits April 7, 2026 09:11
@MarvMa @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/network/NetworkStatusI…
bc30f54 
…mpl.java


Requested changes

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
@hohwille
fixed CHANGELOG
d94dcce 
Updated CHANGELOG with new features and bugfixes for release 2026.04.002.
@hohwille hohwille added this to the release:2026.04.002 milestone Apr 7, 2026
@hohwille
Copy link
Copy Markdown
Member

hohwille commented Apr 7, 2026

FYI: I fixed the CHANGELOG in this PR.
Now we can merge.

@hohwille hohwille merged commit c0f5fa9 into devonfw:main Apr 7, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

@ducminh02 ducminh02 Awaiting requested review from ducminh02

Assignees

@MarvMa MarvMa

@ducminh02 ducminh02

Labels

download download of tools, plugins, code from git, any HTTP traffic over the network enhancement New feature or request

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2026.04.002

Development

Successfully merging this pull request may close these issues.

Let IDEasy automatically add certificates to the truststore

4 participants

@MarvMa @coveralls @hohwille @ducminh02