fix(release): webhook env docs and feedback repo case matching - #431
Merged
devops-thiago merged 2 commits intoJul 27, 2026
Conversation
Align the troubleshooting checklist with the real WEBHOOK_* env vars, and match dashboard feedback filters case-insensitively so access grants and stored webhook casing stay consistent. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
🤖 ThrillhouseBot PR SummaryWhat this PR doesThis PR adds case-insensitive repository matching to the feedback summary and recent-feedback queries, updates the README troubleshooting checklist to use the correct webhook configuration environment variable names, and adds tests for the new case-insensitive behavior. Changes Overview
Changed Files
Risk Assessment
Key Findings
|
| Check | Type | Status | Detail |
|---|---|---|---|
| dependency-review | check-run | ⏳ Pending | - |
Automated review by ThrillhouseBot. Reply with /review to re-run.
![thrillhousebot[bot]](https://avatars.githubusercontent.com/in/3996985?s=60&v=4){kind=small}
thrillhousebot
Bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Order the case-insensitive lookup by repository so summarize returns a stable casing when mixed-case rows exist. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
ThrillhouseBot found no issues in this PR, but some checks are still pending or failed:
- Check actionlint is pending
- Check format is pending
- Check frontend is pending
- Check trivy is pending
- Check changes is pending
- Check build is pending
- Check test is pending
- Check dependency-review is pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Fixes two v0.5.0 Bugbot findings introduced by the structured-skip troubleshooting docs (#341) and finding-feedback dashboard filter (#324 / #423):
WEBHOOK_TRIGGERS_*env vars. Operators following that guidance would set variables the app never reads (WEBHOOK_SKIP_DRAFTS,WEBHOOK_REQUIRED_LABELS,WEBHOOK_EXCLUDED_LABELS,WEBHOOK_BASE_BRANCHES,WEBHOOK_IGNORED_BASE_BRANCHESare the mapped names).GET /api/dashboard/feedback?repository=authorized with case-insensitive repository access, then queried feedback with the raw query casing. Rows stored from webhooks (canonical GitHub casing) were missed when the filter casing differed.FindingFeedbackService.summarize/listRecentnow match case-insensitively and return the stored repository key.Related Issues
N/A — follow-up to #341 / #324 / #423 Bugbot findings on
release/v0.5.0.How Has This Been Tested?
Unit tests
Integration tests
Manual testing
./mvnw -Dtest=FindingFeedbackServiceTest,DashboardResourceTest test— passedNew coverage: case-insensitive summarize/listRecent; dashboard feedback query with differing repository casing
Checklist
Screenshots / Logs
N/A
Additional Notes
Targets
release/v0.5.0so the cut ships with correct operator docs and feedback filtering.