Skip to content

Index of the table Projection starts at 1 not 0 - #33

Open
anshockm wants to merge 1 commit into
dfaker:masterfrom
anshockm:cycle-projections-patch
Open

Index of the table Projection starts at 1 not 0#33
anshockm wants to merge 1 commit into
dfaker:masterfrom
anshockm:cycle-projections-patch

Conversation

@anshockm

Copy link
Copy Markdown

cycleInputProjection and cycleOutputProjection ran out of the limits of their functions:

[360plugin] 
[360plugin] stack traceback:
[360plugin]     [C]: in function 'format'
[360plugin]     /home/user/.config/mpv/scripts/360plugin.lua:445: in function 'fn'
[360plugin]     mp.defaults:230: in function 'fn'
[360plugin]     mp.defaults:65: in function 'handler'
[360plugin]     mp.defaults:382: in function 'handler'
[360plugin]     mp.defaults:512: in function 'call_event_handlers'
[360plugin]     mp.defaults:554: in function 'dispatch_events'
[360plugin]     mp.defaults:505: in function <mp.defaults:504>
[360plugin]     [C]: ?
[360plugin]     [C]: ?
[360plugin] Lua error: /home/user/.config/mpv/scripts/360plugin.lua:445: bad argument #2 to 'format' (string expected, got nil)

This patch fixed that.

llucis added a commit to llucis/unvr-mpv that referenced this pull request Jul 18, 2026
- Fix projection cycling crash: table index wrapped to 0 (nil) every
  full cycle of the 1/2 keys (merges upstream dfaker/VR-reversal#33)
- Fix resolution OSD message reporting height as Out-Width
- Guard against zero-duration lerp() expressions (division by zero) in
  the motion log
- New script opt hwdec (default no): enables GPU copy-back hardware
  decoding while the plugin is active; yes/auto normalize to auto-copy
  since the CPU v360 filter requires copy-back modes
- Write convert_3dViewHistory.sh (executable, one command per line) on
  Linux/macOS instead of a Windows-only .bat joined with '&'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant