fix: handle unspecified node reward type in registry command#1964
Merged
severin-amrein merged 1 commit intomainfrom Apr 2, 2026
Merged
fix: handle unspecified node reward type in registry command#1964severin-amrein merged 1 commit intomainfrom
severin-amrein merged 1 commit intomainfrom
Conversation
The registry command panicked when a node had no node_reward_type set, because NodeRewardType::Unspecified panics on .to_string() in the upstream ic-protobuf crate. Handle this case explicitly by printing "unspecified" instead.
NikolaMilosa
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dre registrycommand panicked when a node had nonode_reward_typeset, becauseNodeRewardType::Unspecifiedpanics on.to_string()in the upstreamic-protobufcrate"unspecified"instead of calling.to_string()on the enum variantTest plan
dre registryagainst mainnet and verified nodes with missing node type now show"unspecified"instead of panicking:{ "node_id": "csr6y-hwdmg-7nzv5-bdqdv-m4pwd-zptyz-dr2yv-tehnb-llgci-jx4sl-aqe", "node_reward_type": "unspecified", ... }