chore: [ANDROSDK-2289] Remove ObjectStyle.Builder class#2594
Merged
vgarciabnz merged 4 commits intodevelopfrom May 5, 2026
Merged
chore: [ANDROSDK-2289] Remove ObjectStyle.Builder class#2594vgarciabnz merged 4 commits intodevelopfrom
vgarciabnz merged 4 commits intodevelopfrom
Conversation
|
taridepaco
reviewed
May 5, 2026
|
|
||
| public abstract Builder fieldMask(String fieldMask); | ||
|
|
||
| public abstract Builder style(ObjectStyle style); |
Collaborator
There was a problem hiding this comment.
why did this model have the style builder setter already here?
Member
Author
There was a problem hiding this comment.
It guess it was unintentional, it shouldn't have been there.
taridepaco
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ObjectWithStyle.Builder inner interface from the ObjectWithStyle interface. This inner interface was used to type the builders and indicate that they include a
style(...)builder property, which was used in the DTO -> domain and DB -> domain conversions. This inner interface introduced some complexity when it comes to inheritance, and it was even more complex with the approach of generated builders for data class. So it was better to just remove it.This PR does:
ObjectWithStyleto a simple interface with thestyle()property.ObjectWithStyleKtinterface for the data classes.toDomainmethod for DTO and DB conversions.ObjectWithStyleto remove the builder extension and add the builder property explicitly.