chore: [ANDROSDK-2288-DATAELEMENT] Migrate DataElement#2596
Merged
vgarciabnz merged 2 commits intodevelopfrom May 7, 2026
Merged
chore: [ANDROSDK-2288-DATAELEMENT] Migrate DataElement#2596vgarciabnz merged 2 commits intodevelopfrom
vgarciabnz merged 2 commits intodevelopfrom
Conversation
vgarciabnz
commented
May 6, 2026
| val dataElementsUids = dataElementCollectionRepository | ||
| .byValueType().`in`(ValueType.FILE_RESOURCE, ValueType.IMAGE) | ||
| .suspendGet().map(DataElement::uid) | ||
| .suspendGet().map { it.uid } |
Member
Author
There was a problem hiding this comment.
This is required because of an ambiguity in the name. Now we have uid() and uid, and it is not able to differentiate the function reference.
taridepaco
approved these changes
May 6, 2026
vgarciabnz
force-pushed
the
ANDROSDK-2288-dataelement
branch
from
04635e6 to
522c8c6
Compare
|
taridepaco
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This model migration introduces the question about the ObjectStyle default value. In the legacy DataElement class, the default value was specified in the builder. It has been kept in the new builder as well. But it does not apply to the default constructor. We can consider if this is something that should go to the network layer.