feat(assets): harden signed manifest lifecycle - #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assetsExpiresAttimestamp with signed cosmetic asset manifests.Cache-Control: private, no-store.GET /cosmetics/:id/assetsGET /me/cosmetics/:id/assetsasset_files, including a migration and an idempotentbun run index:cosmetic-assetsbackfill, to avoid R2ListObjectscalls on the manifest hot path.Why
R2 objects themselves do not expire after 600 seconds; that duration belongs to the presigned URLs. The previous flow treated the client receipt time as the expiry reference, refreshed the full cosmetics catalog, and listed R2 objects for each manifest. This change makes expiry explicit, allows one cosmetic to be refreshed, and moves object discovery out of the request hot path.
Deployment
bun run migration:cosmetics:run.bun run index:cosmetic-assets.The backfill is resumable and idempotent. While
asset_filesis null, the API retains the existing R2 listing fallback.Validation
Compatibility
assetsresponse remains unchanged.assetsExpiresAtis additive, so existing clients continue to work.