Fix CVE-2026-64607, CVE-2026-54399 - #42
Merged
Merged
Conversation
It used an old SEID1 certificate from Buypass, with validity period from several years ago. In order to mitigate this, a Clock set to 2020 was used. Recently Buypass started signing their OCSP responses (which is the specific purpose of this test) with a new a short-lived certificate, in accordance with sunsetting SEID1. With our Clock set to 2020, the validator will not accept a OCSP response signed with a certificate issued in 2026, and the test broke.
It is left for a future developer if this test should rather be deleted. Testing using real certificates, with local time adapted to the cert's validity period, and at the same communicating with a 3rd party external service, is pretty much asking for trouble at some time. See ed89d2f, which purposefully deletes such test.
martin-jackson
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/digipost/certificate-validator/security/dependabot/7
https://github.com/digipost/certificate-validator/security/dependabot/6
Deletes a test which has started to fail due to Buypass sunsetting the old SEID1 rig. See ed89d2f
Statement from Buypass:
(https://www.buypass.no/driftsmeldinger)