fix(credential): unify normalization of context#146
Open
jceb wants to merge 1 commit intodigitalbazaar:mainfrom
Open
fix(credential): unify normalization of context#146jceb wants to merge 1 commit intodigitalbazaar:mainfrom
jceb wants to merge 1 commit intodigitalbazaar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation,
@contextis only normalized for presentations and not for credentials. This PR unifies normalization so that strings are also supported.Having said that, according to the spec
@contextmust be an ordered set: https://w3c.github.io/vc-data-model/#contexts. Not sure if it's a good idea to support this any. Whatever is done, the behavior should be the same for presentations and credentials :-D