character controller example: added 2 slopes to test max/min slopes#532
Draft
ThierryBerger wants to merge 1 commit intodimforge:masterfrom
Draft
Conversation
Contributor
Author
|
Related: dimforge/rapier.js#274 |
ThierryBerger
force-pushed
the
character_controller-max_slope_not_respected
branch
from
7112771 to
aff3484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a report on discord, the
max_slope_climb_angleare not respected in the character controller example.This pull requests only adds 2 slopes to test this behaviour more easily
Analysis
the added example should have the same parameters as rapier:
slope we can climb: https://github.com/dimforge/rapier/blob/master/examples3d/character_controller3.rs#L93
slope we cannot climb: https://github.com/dimforge/rapier/blob/b7347860f71179a4675ec785644abe1bb09e415a/examples3d/character_controller3.rs#L107
character controller parameters: https://github.com/dimforge/rapier/blob/master/src_testbed/testbed.rs#L786
I moved this analysis to rapier, with a first setup PR to help with debugging: Fix character max/min slope rapier#701
Test instructions
run
cargo run --example character_controller3: 2 slopes are present, 1 we should be able to climb, one we shouldn't be able to.