Add target parameter to Vector and Rotation#25
Open
robertlong wants to merge 1 commit intodimforge:masterfrom
Open
Add target parameter to Vector and Rotation#25robertlong wants to merge 1 commit intodimforge:masterfrom
robertlong wants to merge 1 commit intodimforge:masterfrom
Conversation
Member
|
Thank you for this PR! Adding these optional object arguments is a great idea. You may take a look at what the CI does for building rapier and rapier-compat. |
|
@robertlong I am continuing your work in reducing JavaScript object allocation here: #337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed it's not possible to get the rotation/translation of a Collider without allocating a new
VectororRotationobject. Now you can provide an object that implementsVectororRotationsuch asTHREE.Vector3orTHREE.Quaternionand those methods will write values from the RawVector/RawRotation to the provided objects.Also, I was having some issues getting set up to build the libraries so I haven't been able to test this yet.
I have
wasm-packandtypedocinstalled and the latest version of Rust. I'd like to be able to build the compat versions of the library and link them into my project to test.