Add contact modification physics hook support.#360
Open
seurimas wants to merge 6 commits intodimforge:masterfrom
Open
Add contact modification physics hook support.#360seurimas wants to merge 6 commits intodimforge:masterfrom
seurimas wants to merge 6 commits intodimforge:masterfrom
Conversation
…t of the setters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had the need to use contact modification in Javascript, and I noticed it's not supported.
I've uncommented the implementation already there and cleaned it up a little. From a little testing, it seems to work exactly as expected. I've noticed a few elements (rigid body/contact manifold) are missing from the original implementation code and will add those in. What else is needed to get this merged in?