fix(tree-view-table-layout): point the collapsed-row chevron right, not left#320
Open
seltzdesign wants to merge 1 commit into
Open
fix(tree-view-table-layout): point the collapsed-row chevron right, not left#320seltzdesign wants to merge 1 commit into
seltzdesign wants to merge 1 commit into
Conversation
…ot left The expand_more icon points down; the .children-collapsed state rotated it +90deg (clockwise), which points it LEFT. Collapsed nodes should point RIGHT (the universal 'expand me' affordance). Use rotate(-90deg) so it points right; expanding rotates it back down toward the revealed children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a row's children are collapsed, the expand chevron points left. The near-universal convention in tree UIs is that a collapsed node points right ("there is hidden content this way, click to expand"), and rotates down to point at the revealed children when expanded. The current direction reads backwards and makes the affordance ambiguous.
Root cause
The base icon is Material's
expand_more, which points down. The.children-collapsedstate rotates it withtransform: rotate(90deg). A positive 90deg rotation (clockwise) takes a down-pointing arrow to point left, which is the wrong direction for "expand me".Fix
Change the rotation on
.children-collapsedfromrotate(90deg)torotate(-90deg)insrc/components/table-row.vue.-90deg(counter-clockwise) takes the down-pointingexpand_moreto point right, matching the standard expand affordance. A comment next to the rule records the intent so the sign is not "corrected" back later.Verification
Loaded a collection with nested rows: collapsed rows now show a right-pointing chevron, and expanding a row rotates it back down toward the now-visible children. No change to expand/collapse logic, hit area, or any other styling.
Note for reviewers
This PR touches
src/components/table-row.vue, but only the CSStransformhunk in the<style>block (the.children-collapsedrule). A separate PR ("feat: shift-click to expand/collapse the entire subtree") also touches this file, but in a different, non-overlapping hunk — the@clickemit in the<template>. The two changes are independent and do not conflict.