Skip to content

Support multiple interpolation types in media galleries #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quinchs merged 19 commits into from
Dec 14, 2025
Merged

Support multiple interpolation types in media galleries #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
20f9bb1
Initial plan
Copilot Dec 13, 2025
75bdcfc
Merge branch 'main' of https://github.com/discord-net/ComponentDesign…
Copilot Dec 13, 2025
2bf39da
Add Uri interpolation support to media galleries (WIP - test failing)
Copilot Dec 13, 2025
adf0527
Fix Uri interpolation support - all tests passing
Copilot Dec 13, 2025
b97b69d
Refactor to eliminate code duplication
Copilot Dec 13, 2025
73e5eed
Address code review feedback: use state class, IsValidChild, and Know…
Copilot Dec 13, 2025
94d6f91
Add abstraction for string, UnfurledMediaItem, and IEnumerable types;…
Copilot Dec 13, 2025
8005ece
Consolidate duplicate rendering logic for Uri and String cases
Copilot Dec 13, 2025
17f53e1
Address all code review feedback: simplify types, use flags, improve …
Copilot Dec 13, 2025
2a449ca
Fix code review issues: use distinct bit positions, improve exception…
Copilot Dec 13, 2025
39176d7
Fix Uri to string conversion: use .ToString() for UnfurledMediaItemPr…
Copilot Dec 13, 2025
f6958d7
Add expected rendered code to tests and update README with interpolat…
Copilot Dec 13, 2025
b84960b
Update README.md
quinchs Dec 13, 2025
ee62f64
Add expected rendered code for GalleryMixingItemsAndUriInterpolations…
Copilot Dec 13, 2025
69d20f5
Fix GalleryMixingItemsAndUriInterpolations test - remove expected out…
Copilot Dec 13, 2025
51c76d9
Document known limitation with alternating items and interpolations
Copilot Dec 13, 2025
7002156
Fix GPT code
quinchs Dec 14, 2025
2100e98
Merge branch 'copilot/improve-media-gallery-functionality' of https:/…
quinchs Dec 14, 2025
107ab14
fix tests
quinchs Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,19 @@ A Media Gallery allows you to display media attachments in an organized format.

#### Valid children
- [Media Gallery Item](#media-gallery-item)
- Interpolations of supported types:
- `Uri`
- `string`
- `UnfurledMediaItemProperties`
- `IEnumerable<T>` of the above

```html
<media-gallery id={123}>
...
<item url="https://example.com/1.png" />
{myUri}
{myStringUrl}
{myUnfurledItem}
{myUriCollection}
</media-gallery>
```

Expand Down
Loading
Loading