Skip to content
This repository was archived by the owner on Dec 24, 2021. It is now read-only.

fix: replace resolveString with verifyString#402

Open
monbrey wants to merge 6 commits into
discordjs:masterfrom
monbrey:verify-string
Open

fix: replace resolveString with verifyString#402
monbrey wants to merge 6 commits into
discordjs:masterfrom
monbrey:verify-string

Conversation

@monbrey

@monbrey monbrey commented Jun 4, 2021

Copy link
Copy Markdown
Member

Replaces a reference to the now removed Util.resolveString with Util.verifyString
Introduced by discordjs/discord.js#4880

Comment thread src/extensions/message.js Outdated
@ghost

ghost commented Jun 4, 2021

Copy link
Copy Markdown

I just tested this PR and looks like this.options is giving the error TypeError: Cannot read property 'content' of undefined, without the this.options is working fine

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out this.options

@ghost

ghost commented Jun 9, 2021

Copy link
Copy Markdown

Shouldn't StringResolvable be Replaced with string in the Typings?

@kyranet

kyranet commented Jun 9, 2021

Copy link
Copy Markdown
Member

StringResolvable is being used for message sending and editing, both of which are changing in discordjs/discord.js#5758

Once the PR has landed, this can be updated and fix two breaking changes together.

@monbrey

monbrey commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

I don't believe this PR should address both changes, no. I will update the typing though.

@kyranet

kyranet commented Jun 9, 2021

Copy link
Copy Markdown
Member

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

@ghost

ghost commented Jun 9, 2021

Copy link
Copy Markdown

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

There are a lot of things missing to support v13, This is getting kinda off-topic lets discuss on library-discussion if You want.

@arifali123

Copy link
Copy Markdown

can this be merged so we can use commando with the master version of discord.js

@ghost

ghost commented Jun 29, 2021

Copy link
Copy Markdown

This PR just Broke lmao, now You get verifyString is not a function

@kyranet

kyranet commented Jun 29, 2021

Copy link
Copy Markdown
Member

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Separate imports to escapeMarkdown, splitMessage, verifyString
const { // Imports } = require('discord.js').Util;

@ghost

ghost commented Jun 29, 2021

Copy link
Copy Markdown

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

Yea I didn't changed back to 12, He Just forgot to add .Util after requiring d.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants