Add box-shadow to sticky header#6896
Merged
bdukes merged 2 commits intodnnsoftware:developfrom Apr 20, 2026
Merged
Conversation
valadas
reviewed
Jan 8, 2026
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
I will let others chime in. I for one find it a bit too strong or a shadow with this value:
I prefer the more subtle value I had documented in the issue:
mitchelsellers
requested changes
Feb 26, 2026
Contributor
|
@valadas Can you review my proposed update above? |
valadas
approved these changes
Apr 19, 2026
Contributor
|
Love it |
mitchelsellers
approved these changes
Apr 19, 2026
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
auto-merge was automatically disabled
April 20, 2026 13:27
Head branch was pushed to by a user without write access
Merged
via the queue into
dnnsoftware:develop
with commit Apr 20, 2026
26fd0e4
8 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6755
Summary
Header separation on scroll
Adds a subtle box-shadow to the header when scrolling to improve visual separation from the page content.
This prevents the header from visually blending into the content below while preserving the existing layout and behavior.