Open
Conversation
bdukes
force-pushed
the
obsolete
branch
3 times, most recently
from
8d52554 to
0f943b6
Compare
bdukes
force-pushed
the
obsolete
branch
7 times, most recently
from
31372d4 to
70fadfc
Compare
valadas
requested changes
Feb 24, 2026
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
Left a few comments/questions but the major issue is that casing was changed on some API controllers returns that are causing issues in the frontend, most notably the Site Settings persona bar module is not working.
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Show resolved
Hide resolved
Contributor
Author
|
I appreciate the review and testing @valadas, I know these PRs that are all over the place are hard to review. |
Contributor
Ya think! But seriously, the work is appreciated and happy to review/test. I will retest this a bit later for my final stamp, but looks good now, thanks! |
Pass in dependencies to FileManager via constructor
Also migrate to primary constructors where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves obsolete warnings in DotNetNuke.Library from 1,205 to 1,016.