Skip to content

Conversation

@davidhay1969
Copy link

Resolving a few linting and bouncer issues

  • Updated internal/logger/logrus.go to handle ioutil deprecation
  • Updated cmd/event_loop.go to handle linting issues
  • Updated .bouncer.yaml to ignore crypto/internal/boring

Signed-off-by: Dave Hay [email protected]

Upping from 1.45.0 to 1.50.1 to avoid panic

Signed-off-by: Dave Hay <[email protected]>
- Fixed internal/logger/logrus.go to remove deprecate ioutil package
- Fixed cmd/event_loop.go to resolve linting issue
- Updated .bouncer.yaml to ignore crypto/internal/boring

Signed-off-by: Dave Hay <[email protected]>
@davidhay1969
Copy link
Author

logrus.go change

internal/logger/logrus.go:10:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^

event_loop.go change

cmd/event_loop.go:17:1: directive `// nolint:funlen` should be written without leading space as `//nolint:funlen` (nolintlint)
// nolint:funlen
^

.bouncer.yaml change

Unallowable license (OpenSSL) from "crypto/internal/boring"
failed validation
make: *** [Makefile:114: check-licenses] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant