Open
Conversation
The legacy dojoup/dojoup script and its associated infrastructure have been replaced by asdf-based plugins (sozo, katana, torii, saya). This removes: - dojoup/dojoup (legacy shell installer) - dojoup/dojoup-install (bootstrap for legacy script) - dojoup/post_install_check (legacy test suite) - dojoup/Dockerfile (legacy CI) Also updated: - dojoup/README.md to document the new asdf-based installation - bin/sozo/README.md to fix title - .devcontainer/devcontainer.json to remove legacy path - dojoup/install.ps1 to use GitHub API instead of versions.json Fixes #3400
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Ohayo, sensei! WalkthroughRemoved the legacy dojoup installer ecosystem and related artifacts: the shell installer, its installer bootstrap, PowerShell installer, post-install test suite, and Dockerfile. Documentation and a devcontainer PATH entry were updated to reflect the removal. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
dojoup/install.ps1 (1)
56-62: Ohayo sensei — prefer pipeline-friendly output cmdlets overWrite-Host.Using
Write-Information/Write-Verbosehere keeps output redirectable and easier to automate.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@dojoup/install.ps1` around lines 56 - 62, Replace the pipeline-terminating Write-Host calls with pipeline-friendly output cmdlets: use Write-Information for the main installation status messages (e.g., the "Installed $($tool.Name) v$version" and "Dojo toolchain installation complete!" messages) and/or Write-Verbose for optional progress lines; keep Add-ToPath and $installDir unchanged. Update the calls to include meaningful Tags or MessageData if needed and ensure callers can see messages by documenting or setting appropriate -InformationAction/-Verbose switches when running the script.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dojoup/install.ps1`:
- Line 2: Update the stale usage comment in install.ps1: remove the “[version]”
argument from the shebang/usage line and replace it with the current invocation
signature (e.g. "Usage: powershell -ExecutionPolicy Bypass -File install.ps1")
so the top-of-file comment accurately reflects that install.ps1 no longer
accepts a version parameter; edit the comment line shown in the diff
accordingly.
---
Nitpick comments:
In `@dojoup/install.ps1`:
- Around line 56-62: Replace the pipeline-terminating Write-Host calls with
pipeline-friendly output cmdlets: use Write-Information for the main
installation status messages (e.g., the "Installed $($tool.Name) v$version" and
"Dojo toolchain installation complete!" messages) and/or Write-Verbose for
optional progress lines; keep Add-ToPath and $installDir unchanged. Update the
calls to include meaningful Tags or MessageData if needed and ensure callers can
see messages by documenting or setting appropriate -InformationAction/-Verbose
switches when running the script.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 24987dc1-599d-4531-a7ae-3f887e1a9ec2
📒 Files selected for processing (8)
.devcontainer/devcontainer.jsonbin/sozo/README.mddojoup/Dockerfiledojoup/README.mddojoup/dojoupdojoup/dojoup-installdojoup/install.ps1dojoup/post_install_check
💤 Files with no reviewable changes (4)
- dojoup/post_install_check
- dojoup/dojoup-install
- dojoup/Dockerfile
- dojoup/dojoup
dojoup/install.ps1
Outdated
| @@ -1,92 +1,63 @@ | |||
| # Function to download and extract a zip file | |||
| # Dojo toolchain installer for Windows | |||
| # Usage: powershell -ExecutionPolicy Bypass -File install.ps1 [version] | |||
Contributor
There was a problem hiding this comment.
Ohayo sensei — usage comment is stale.
Line 2 still advertises [version], but the script does not accept a version argument anymore.
Proposed doc fix
-# Usage: powershell -ExecutionPolicy Bypass -File install.ps1 [version]
+# Usage: powershell -ExecutionPolicy Bypass -File install.ps1📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # Usage: powershell -ExecutionPolicy Bypass -File install.ps1 [version] | |
| # Usage: powershell -ExecutionPolicy Bypass -File install.ps1 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@dojoup/install.ps1` at line 2, Update the stale usage comment in install.ps1:
remove the “[version]” argument from the shebang/usage line and replace it with
the current invocation signature (e.g. "Usage: powershell -ExecutionPolicy
Bypass -File install.ps1") so the top-of-file comment accurately reflects that
install.ps1 no longer accepts a version parameter; edit the comment line shown
in the diff accordingly.
The legacy PowerShell installer had version compatibility issues and no test coverage. Windows users can download binaries directly from GitHub releases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the legacy dojoup/dojoup shell installer and associated infrastructure that have been replaced by asdf-based plugins (sozo, katana, torii, saya).
Deleted
Updated
Related issue
Fixes #3400
Tests
Added to documentation?
Checklist
Summary by CodeRabbit
Documentation
Chores