ef work

[Savestate2A03]

ef work

• efSpecial -> efAlt

  • this is due to having started work on this after the change to efSpecial was made.

• efdata.c New file that holds static data for ef, moved from eflib_alloc and other data regions.

• efsync.c .sdata now matches

• efasync.c efAsync_Spawn now matches

• efasync.c .sdata now matches

• efSync_Spawn: slightly better match

• efAsync_Dispatch: slightly better match

• Gave descriptive naming to ef-related functions

  • Feel free to change any of these, I am not attached to them

[decomp-dev]

Report for GALE01 (cc79fe5 - 70689a4)

📈 Matched code: 59.22% (+0.02%, +656 bytes)
Total data: 1211276 bytes (-13 bytes)
📈 Matched data: 37.70% (+0.00%, +27 bytes)
📉 Linked data: 32.22% (+0.00%, -4 bytes)

✅ 9 new matches

Unit	Item	Bytes	Before	After
main/melee/ef/efalt	efAlt_Spawn	+7104	0.00%	100.00%
main/melee/ef/efalt	.data	+300	0.00%	100.00%
main/melee/ef/efdata	.bss	+44	0.00%	100.00%
main/melee/ef/efalt	.sdata2	+36	0.00%	100.00%
main/melee/ef/efalt	.sdata	+13	0.00%	100.00%
main/melee/ef/efdata	.sbss	+12	0.00%	100.00%
main/melee/ef/efsync	.sdata	+2	74.29%	100.00%
main/melee/ef/efasync	efAsync_Spawn	+1	99.88%	100.00%
main/melee/ef/efasync	.sdata	-4	95.24%	100.00%

🥀 6 broken matches

Unit	Item	Bytes	Before	After
main/melee/ef/efspecial	efSpecial_SpawnSpecial	-7104	100.00%	0.00%
main/melee/ef/efspecial	.data	-300	100.00%	0.00%
main/melee/ef/eflib_alloc	.bss	-44	100.00%	0.00%
main/melee/ef/efspecial	.sdata2	-36	100.00%	0.00%
main/melee/ef/eflib	.sbss	-16	100.00%	0.00%
main/melee/ef/efspecial	.sdata	-13	100.00%	0.00%

📈 2 improvements in unmatched items

Unit	Item	Bytes	Before	After
main/melee/ef/efsync	efSync_Spawn	+192	95.90%	98.28%
main/melee/ef/efasync	efAsync_Dispatch	+21	98.46%	98.60%

📉 1 regression in an unmatched item

Unit	Item	Bytes	Before	After
main/melee/ef/efasync	.data	-1072	65.93%	24.82%

[Savestate2A03]

this is jumptable related, it will be inherently fixed once the associated function matches i believe