Fix tuple comparison logic and record_le operator#2815
Open
AniruthKarthik wants to merge 1 commit into
Open
Conversation
AniruthKarthik
force-pushed
the
fix-tuple-comparison-2807
branch
from
c540331 to
fbf804d
Compare
Author
|
@dolthub/doltgresql-maintainers @coffeegoddd Merge conflicts resolved and rebased. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2807 where tuple comparisons (specifically greater-than) were returning incorrect results due to lexicographical comparison logic in
CompareRecords.Changes:
CompareRecordsinserver/compare/utils.goto correctly returnfalsefor<and>when element comparison determines it.CompareRecordsto distinguish between equality-based and inequality-based operators.record_leinserver/functions/binary/less_equal.goto use theLessOrEqualoperator.callComparisonFunction.server/compare/utils_test.gocovering various comparison operators and NULL cases.Fixes #2807