Add requirements to README.md #183
Conversation
README.md
Outdated
| - Yarn: `npm install -g yarn` to install yarn globally | ||
| - Bun: `npm install -g bun` to install bun globally |
There was a problem hiding this comment.
both of these package managers have their preferred way of installing themselves, can we link to their install page on their site instead?
There was a problem hiding this comment.
Absolutely! Feel free to adjust to the way you feel is more appropriate. I setup the environment for myself and realised I didn't meet the requirements, hence I figured it might be a good idea to add it into the readme :)
Or do you prefer if I update the PR?
Not sure how people usually do it.
There was a problem hiding this comment.
yes please feel free to update the pr! usually that's how people do it :) tysm for your contributions! did the setup work for you? curious if you learned anything else
There was a problem hiding this comment.
Sorry for the delay. It should be updated now.
I didn't actually start the application, I just set it up 😄 so there might still be more things one have to do. But at least the readme is a bit improved now.
I did look through some of the code though, and of course package.json as I was curious about the dependencies. It's awfully many dependencies? But maybe they're all required.
I did look at Zod, I've actually used it before but forgotten about it. Was nice to be reminded about it. I also decided to use TanStack router in my next project at work, so I actually incorporated it last week.
You seem to have date-fns and dayjs, is both really required?
Oh and I saw this
I'm not fully sure about when to use "unknown", why not cast it directly to ReturnType<typeof create7TVClient>?
I'm sure there is more for me to learn if I just have the time to inspect more code .
2 participants
No description provided.