[marshal methods] Make AndroidEnvironmentInternal.UnhandledException public#10775
Merged
jonathanpeppers merged 5 commits intomainfrom Feb 6, 2026
Merged
[marshal methods] Make AndroidEnvironmentInternal.UnhandledException public#10775jonathanpeppers merged 5 commits intomainfrom
jonathanpeppers merged 5 commits intomainfrom
Conversation
…odAccessException Co-authored-by: Marek Habersack <grendel@twistedcode.net> Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: Marek Habersack <grendel@twistedcode.net> Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix crashes due to inaccessible Android method
[marshal methods] Make AndroidEnvironmentInternal.UnhandledException public
Feb 5, 2026
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marek Habersack <grendel@twistedcode.net> Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: Marek Habersack <grendel@twistedcode.net> Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR fixes MethodAccessException crashes from marshal method wrappers by making Android.Runtime.AndroidEnvironmentInternal.UnhandledException(Exception) accessible outside Mono.Android.dll, while attempting to keep the API “hidden” from normal IntelliSense usage.
Changes:
- Made
AndroidEnvironmentInternaland itsUnhandledExceptionmethod public, both annotated with[EditorBrowsable (EditorBrowsableState.Never)]. - Added a build test that inspects the linked
Mono.Android.Runtime.dllto ensure the type/method are public.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Mono.Android.Runtime/Android.Runtime/AndroidEnvironmentInternal.cs | Exposes the previously-internal runtime hook used by marshal method wrappers. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs | Adds a regression test validating the linked runtime assembly contains the now-public API. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs
Show resolved
Hide resolved
simonrozsival
approved these changes
Feb 6, 2026
jonathanpeppers
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #10602 where marshal method wrappers would crash with
MethodAccessExceptionwhen callingAndroid.Runtime.AndroidEnvironmentInternal.UnhandledException().Changes
AndroidEnvironmentInternalclass public with[EditorBrowsable(EditorBrowsableState.Never)]attributeUnhandledExceptionmethod public with[EditorBrowsable(EditorBrowsableState.Never)]attributeMarshalMethodsUnhandledExceptionRuntimeFixUpWorks(matching @grendello's version from PR [marshal methods] Make AndroidEnvironmentInternal.UnhandledException … #10607, with additional method assertions)Note: Removed
[DebuggerBrowsable]attributes as they are only valid on properties, indexers, and fields - not on types or methods.Original prompt
Method Android.Runtime.AndroidEnvironmentInternal.UnhandledException(System.Exception) is inaccessible (...)exception #10602✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.