Add SkipStatusCodePages property to ApiBehaviorOptions - #68098
Open
aw0lid wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your PR, @aw0lid. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SkipStatusCodePages property to ApiBehaviorOptions
Description
This PR implements the approved API proposal to add the
SkipStatusCodePagesproperty toApiBehaviorOptions.What was done:
SkipStatusCodePagesboolean property toApiBehaviorOptions.ApiBehaviorApplicationModelProviderto check ifSkipStatusCodePagesis set totrue. When enabled and targeting an API Controller (ApiControllerAttribute), it automatically injectsSkipStatusCodePagesMetadata.Instanceinto the action's route selectors.PublicAPI.Unshipped.txtto include the new property.Tests Added:
Added unit tests in
ApiBehaviorApplicationModelProviderTest.cscovering the following scenarios:SkipStatusCodePages = trueon an API Controller.SkipStatusCodePages = trueon a non-API Controller.SkipStatusCodePages = false.Fixes #45369