Harden RefreshSignInCoreAsync to revalidate cookie always - #68103
Open
cincuranet wants to merge 2 commits into
Open
Harden RefreshSignInCoreAsync to revalidate cookie always#68103cincuranet wants to merge 2 commits into
cincuranet wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens SignInManager.RefreshSignInAsync by ensuring the current authentication cookie’s security stamp is revalidated (after confirming the caller is the currently-authenticated user) before re-issuing the sign-in cookie, addressing #68084.
Changes:
- Added a security-stamp validation step in
RefreshSignInCoreAsyncprior to callingSignInWithClaimsAsync. - Added new unit tests covering both the “stale stamp prevents refresh” and “matching stamp allows refresh” cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Identity/Core/src/SignInManager.cs | Validates the presented security stamp before re-issuing the application cookie during refresh sign-in. |
| src/Identity/test/Identity.Test/SignInManagerTest.cs | Adds tests verifying refresh sign-in is blocked for stale stamps and allowed for matching stamps. |
cincuranet
marked this pull request as ready for review
July 31, 2026 09:01
javiercn
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68084