Fix Flaky HTTP/3 Test: POST_ClientCancellationUpload_RequestAbortRaised - #68111
Open
PreethikaSelvam wants to merge 3 commits into
Open
Fix Flaky HTTP/3 Test: POST_ClientCancellationUpload_RequestAbortRaised#68111PreethikaSelvam wants to merge 3 commits into
POST_ClientCancellationUpload_RequestAbortRaised#68111PreethikaSelvam wants to merge 3 commits into
Conversation
Contributor
|
Thanks for your PR, @PreethikaSelvam. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent failures in Http3RequestTests.POST_ClientCancellationUpload_RequestAbortRaised caused by timing-dependent behavior when reading the request body after client cancellation in HTTP/3.
Validation / Investigation
The failing test intermittently reported:
Assert.Throws() Failure: No exception was thrown Expected: typeof(System.IO.IOException)To investigate the issue, the test was executed in a local stress run of 1000 iterations, during which the failure was successfully reproduced. Analysis of both local and CI failures confirmed that:
The flakiness was caused by the final request body read after cancellation. Depending on timing, two valid outcomes were observed:
ReadAsync() throws:
IOException("The client reset the request stream.")ReadAsync() completes successfully and returns:
0indicating EOF.
The existing test only accepted the exception path, causing intermittent failures whenever EOF was observed instead.
Validation
Changes
Fixes #67518 & #58802