Skip to content

IL: reuse the cached ILTypeRef in ILTypeInfo.FromType #20255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auduchinok wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −7
Open

IL: reuse the cached ILTypeRef in ILTypeInfo.FromType #20255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f77f7
Reuse the cached ILTypeRef in ILTypeInfo.FromType
auduchinok Aug 13, 2026
3c52801
Release notes
auduchinok Aug 13, 2026
3953d3d
Cleanup
auduchinok Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/11.0.100.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@
* Support for the `<include>` XML documentation tag: at compile time, documentation is copied from an external XML file selected by an XPath query and emitted into the generated documentation file. `<inheritdoc>` remains unsupported. ([Issue #19175](https://github.com/dotnet/fsharp/issues/19175), [PR #19186](https://github.com/dotnet/fsharp/pull/19186))
* Expand `<inheritdoc/>` at tooling time. In IDE tooltips, completion, and signature help, documentation is inherited from base classes, interfaces, overridden members, and constructors (matched by parameter signature). The FCS Symbols API (`FSharpSymbol.XmlDoc`) additionally resolves explicit `cref` targets, but does not expand constructor inheritance. The compiler emits the tag verbatim into generated XML documentation files, matching C#; `<include>` is not implemented. ([Issue #19175](https://github.com/dotnet/fsharp/issues/19175), [PR #19188](https://github.com/dotnet/fsharp/pull/19188))
* Add symbol and type highlighting to F# diagnostics ([PR #20097](https://github.com/dotnet/fsharp/pull/20097))
* IL: reuse the cached ILTypeRef in ILTypeInfo.FromType ([PR #20255](https://github.com/dotnet/fsharp/pull/20255))

### Improved

Expand Down
12 changes: 5 additions & 7 deletions src/Compiler/Checking/infos.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,14 +461,12 @@ type ILTypeInfo =
let metadataTy = convertToTypeWithMetadataIfPossible g ty
assert (isILAppTy g metadataTy)
let metadataTyconRef = tcrefOfAppTy g metadataTy
let (TILObjectReprData(scoref, enc, tdef)) = metadataTyconRef.ILTyconInfo
let metadataILTypeRef = mkRefForNestedILTypeDef scoref (enc, tdef)
ILTypeInfo(g, ty, metadataILTypeRef, tdef)
let (TILObjectReprData(_, _, tdef)) = metadataTyconRef.ILTyconInfo
ILTypeInfo(g, ty, metadataTyconRef.CompiledRepresentationForNamedType, tdef)
elif isILAppTy g ty then
let tcref = tcrefOfAppTy g ty
let (TILObjectReprData(scoref, enc, tdef)) = tcref.ILTyconInfo
let tref = mkRefForNestedILTypeDef scoref (enc, tdef)
ILTypeInfo(g, ty, tref, tdef)
let (TILObjectReprData(_, _, tdef)) = tcref.ILTyconInfo
ILTypeInfo(g, ty, tcref.CompiledRepresentationForNamedType, tdef)
else
failwith ("ILTypeInfo.FromType - no IL metadata for type" + Environment.StackTrace)

Expand Down Expand Up @@ -2652,4 +2650,4 @@ let (|DifferentGetterAndSetter|_|) (pinfo: PropInfo) =
// Getter has an index parameter
getValReprInfo.TotalArgCount > 1 -> ValueSome (getValRef, setValRef)
| _ -> ValueNone
| _ -> ValueNone
| _ -> ValueNone
Loading