[Foundation] Fix nullability in NSStream. #24308

rolfbjarne · 2025-11-20T16:42:16Z

This is file 18 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullable reference types
Removed four [SupportedOSPlatform] attributes without version numbers from NSStreamSocksOptions class
Made fields in NSStreamSocksOptions nullable where appropriate (HostName, Username, Password)
Made return types nullable: indexer, SocksOptions, DataWrittenToMemoryStream, FileCurrentOffset, and out parameters in CreatePair methods
Replaced xml include directive with inline documentation from Item(Foundation.xml file
Removed Item(Foundation.xml file as it only contained the now-inlined documentation
Replaced "To be added." XML documentation with proper documentation for all methods and properties
Added see cref attributes throughout for better cross-referencing
Removed unnecessary whitespace in XML comments
Replaced manual null checks with ArgumentNullException.ThrowIfNull
Fixed typo in example code (Passowrd -> Password)
Improved formatting and consistency in XML documentation

Contributes towards #17285.

This is file 18 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Removed four [SupportedOSPlatform] attributes without version numbers from NSStreamSocksOptions class - Made fields in NSStreamSocksOptions nullable where appropriate (HostName, Username, Password) - Made return types nullable: indexer, SocksOptions, DataWrittenToMemoryStream, FileCurrentOffset, and out parameters in CreatePair methods - Replaced xml include directive with inline documentation from Item(Foundation.xml file - Removed Item(Foundation.xml file as it only contained the now-inlined documentation - Replaced "To be added." XML documentation with proper documentation for all methods and properties - Added see cref attributes throughout for better cross-referencing - Removed unnecessary whitespace in XML comments - Replaced manual null checks with ArgumentNullException.ThrowIfNull - Fixed typo in example code (Passowrd -> Password) - Improved formatting and consistency in XML documentation Contributes towards #17285.

Copilot

Pull Request Overview

This PR enables nullable reference types for NSStream.cs as part of the ongoing effort to enable nullability across the Foundation namespace. The changes focus on proper null safety annotations and documentation improvements.

Enabled #nullable enable and added nullable annotations to properties, fields, and method parameters where appropriate
Replaced manual null checks with ArgumentNullException.ThrowIfNull following established patterns
Improved XML documentation by inlining external documentation, adding proper cross-references, and fixing inconsistencies

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Foundation/NSStream.cs	Enabled nullable reference types, added nullable annotations to properties/parameters/fields, replaced manual null checks with ArgumentNullException.ThrowIfNull, improved and inlined XML documentation, removed unnecessary SupportedOSPlatform attributes from NSStreamSocksOptions class, and fixed typo in example code
docs/api/Foundation.NSStream/Item(Foundation.xml	Removed file as its documentation was inlined into NSStream.cs

…ullability-18-nsstream

vs-mobiletools-engineering-service2 · 2025-12-03T08:52:37Z

✅ [CI Build #79cc511] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:07:55Z

✅ [PR Build #79cc511] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:18:25Z

✅ [CI Build #79cc511] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:30:34Z

💻 [CI Build #79cc511] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:38:22Z

💻 [CI Build #79cc511] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:38:28Z

💻 [CI Build #79cc511] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:41:54Z

💻 [CI Build #79cc511] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:44:33Z

💻 [CI Build #79cc511] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T09:45:19Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

vs-mobiletools-engineering-service2 · 2025-12-03T10:18:39Z

🚀 [CI Build #79cc511] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 130 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 79cc511034e8372197072f5b0f8ba3c0cf92020d [PR build]

rolfbjarne enabled auto-merge (squash) November 20, 2025 16:42

rolfbjarne requested a review from Copilot November 20, 2025 16:42

Copilot started reviewing on behalf of rolfbjarne November 20, 2025 16:42 View session

Copilot finished reviewing on behalf of rolfbjarne November 20, 2025 16:44

Copilot AI reviewed Nov 20, 2025

View reviewed changes

dalexsoto approved these changes Nov 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

50ae10b

…ullability-18-nsstream

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

79cc511

…ullability-18-nsstream

rolfbjarne merged commit f820115 into main Dec 3, 2025
45 checks passed

[Foundation] Fix nullability in NSStream. #24308

[Foundation] Fix nullability in NSStream. #24308

Uh oh!

Conversation

rolfbjarne commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 3, 2025

✅ [CI Build #79cc511] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

✅ [PR Build #79cc511] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

✅ [CI Build #79cc511] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

💻 [CI Build #79cc511] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

💻 [CI Build #79cc511] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

💻 [CI Build #79cc511] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

💻 [CI Build #79cc511] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

💻 [CI Build #79cc511] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 3, 2025

🚀 [CI Build #79cc511] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants