-
Notifications
You must be signed in to change notification settings - Fork 549
[Foundation] Fix nullability in NSScriptCommandDescription. #24351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Foundation] Fix nullability in NSScriptCommandDescription. #24351
Conversation
This is file 22 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made description field nullable (NSScriptCommandDescriptionDictionary?) - Made GetTypeForArgument return type nullable (string?) as it can return null - Made Dictionary property return type nullable (NSDictionary?) with null-conditional access - Changed private static fields to static readonly for better practices - Replaced manual null checks with ArgumentNullException.ThrowIfNull - Fixed typo in comment: "kyes" -> "keys" and "apple" -> "Apple" - Replaced "To be added." XML documentation with proper documentation for all members - Added comprehensive documentation for Create method with exception documentation - Added see cref attributes throughout for better cross-referencing - Removed unnecessary whitespace in XML comments while preserving correct indentation - Added exception documentation where appropriate Contributes towards #17285.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables nullable reference types for NSScriptCommandDescription in the Foundation namespace, part of a larger effort to add nullability support across 47 Foundation files. The changes properly annotate nullable types, improve validation using ArgumentNullException.ThrowIfNull, fix typos, and replace placeholder XML documentation with comprehensive descriptions.
Key changes:
- Enabled
#nullable enableand added proper nullability annotations to fields, properties, and return types - Replaced manual null checks with
ArgumentNullException.ThrowIfNullfollowing .NET 9+ conventions - Enhanced XML documentation from placeholder "To be added." text to detailed descriptions with proper cross-references
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ullability-22-nsscriptcommanddescription
✅ [PR Build #2db82b3] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #2db82b3] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #2db82b3] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #2db82b3] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #2db82b3] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #2db82b3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #2db82b3] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #2db82b3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #2db82b3] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 130 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 22 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.