[Foundation] Fix nullability in NSRange. #24356
Conversation
This is file 24 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Removed four [SupportedOSPlatform] attributes without version numbers from NSRange struct - Made Equals(object) parameter nullable (object?) as per standard pattern - Replaced "To be added." XML documentation with proper documentation for all members - Added comprehensive documentation for struct, fields, constructor, and methods - Enhanced remarks with description of NSRange usage in Foundation - Added see cref attributes throughout for better cross-referencing - Removed unnecessary whitespace in XML comments while preserving correct indentation - Added detailed returns documentation for all methods - Improved ToString documentation to specify the exact format Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
This PR enables nullable reference types for the NSRange struct in Foundation, which is file 24 of 47 files being converted as part of issue #17285. The changes improve code quality by adding proper nullability annotations and replacing placeholder documentation with comprehensive descriptions.
Key changes:
- Enabled nullable reference types by adding
#nullable enable - Made
Equals(object? obj)parameter nullable following .NET conventions - Replaced all "To be added." XML documentation with detailed descriptions
- Removed four entries from Documentation.KnownFailures.txt for methods that now have proper documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Foundation/NSRange.cs | Enabled nullable reference types, added comprehensive XML documentation for all members (struct, fields, constructor, and methods), removed [SupportedOSPlatform] attributes without version numbers, and made Equals(object) parameter nullable |
| tests/cecil-tests/Documentation.KnownFailures.txt | Removed four NSRange method entries that now have proper documentation (constructor, Equals methods, and GetHashCode) |
✅ [CI Build #076de69] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #076de69] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #076de69] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #076de69] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #076de69] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #076de69] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #076de69] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #076de69] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #076de69] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 24 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.