[dotnet] Make sure the current MSI version is higher than the last inserted MSI version. #24374
Conversation
…serted MSI version. Work around a problem where our MSI version is unconveniently correct: some time ago we fixed a bug where the MSI version was wildly incorrect, but the side effect is that now our MSI version is lower than the last MSI version inserted into VS. So come up with a versioning scheme that ends up with an MSI version that's higher than the last MSI version inserted into VS.
There was a problem hiding this comment.
Pull request overview
This PR implements a workaround for an MSI versioning issue specific to .NET 10. Previously, a bug fix corrected wildly incorrect MSI versions, but as a side effect, the new correct versions are now lower than the last MSI version inserted into Visual Studio (255.220.39248). Since VS cannot accept lower MSI versions, the PR introduces a custom versioning scheme for .NET 10 that generates MSI versions higher than the problematic minimum.
Key Changes:
- Adds Xcode version-based calculation for MSI minor version bumps
- Introduces per-platform commit distance tracking in the version calculation
- Adds validation logic to apply custom versioning only for .NET 10 (not needed for .NET 11+)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/generate-vs-workload/generate-vs-workload.cs | Adds xcodeVersion and commitDistances variables; implements custom MSI version calculation for .NET 10 that bumps the minor version based on Xcode version and uses commit distance for build version |
| dotnet/Makefile | Passes per-platform commit distances to the generate-vs-workload script via new --commit-distance- arguments |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <[email protected]>
✅ [CI Build #f25223e] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #f25223e] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #f25223e] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #f25223e] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #f25223e] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #f25223e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #f25223e] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #f25223e] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #f25223e] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 120 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Work around a problem where our MSI version is unconveniently correct: some
time ago we fixed a bug where the MSI version was wildly incorrect, but the
side effect is that now our MSI version is lower than the last MSI version
inserted into VS.
So come up with a versioning scheme that ends up with an MSI version that's
higher than the last MSI version inserted into VS.