[tests] Fix Microsoft.Macios.Transformer.Tests.csproj to only build apidefinition-*.dll variants that are enabled when building locally. #24383
Conversation
…pidefinition-*.dll variants that are enabled when building locally. The 'apidefinition' target already only builds the enabled target platforms, so there's no need to duplicate the platform selection logic in this csproj.
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test project's build target by removing duplicated platform selection logic. The change delegates to the Makefile's apidefinition target, which already handles building only the enabled platforms based on the DOTNET_PLATFORMS variable set during configuration.
Key Changes:
- Replaced four conditional
Execcommands with a single unconditional command that callsmake apidefinition - Removed the logic checking
BUILD_BUILDIDandDOTNET_PLATFORMS.Contains()conditions - Simplified maintenance by eliminating duplication of platform selection logic between the csproj and Makefile
✅ [CI Build #e4b1262] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #e4b1262] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #e4b1262] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #e4b1262] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #e4b1262] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #e4b1262] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #e4b1262] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #e4b1262] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🔥 [CI Build #e4b1262] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 129 tests passed. Failures❌ linker tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
The 'apidefinition' target already only builds the enabled target platforms,
so there's no need to duplicate the platform selection logic in this csproj.