[release/10.0] JIT: Handle FIELD_LIST for tailcall arg/parameter interference checks
#122287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT bug where tailcall argument values could be corrupted when forwarding parameters to other functions. The issue was a regression in .NET 10 where new tailcall scenarios exposed incomplete handling of FIELD_LIST operands in interference checks.
- Introduces
FirstOperandhelper method to correctly traverse complex operand structures includingFIELD_LIST - Updates tailcall argument interference detection to handle non-atomic copies (such as
FIELD_LISToperands) - Adds regression test to verify the fix
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/JitBlue/Runtime_122138/Runtime_122138.csproj | Test project configuration for the regression test |
| src/tests/JIT/Regression/JitBlue/Runtime_122138/Runtime_122138.cs | Regression test that reproduces the tailcall argument corruption scenario with nullable parameters |
| src/coreclr/jit/lower.h | Declares new FirstOperand helper method |
| src/coreclr/jit/lower.cpp | Implements FirstOperand helper and updates LowerFastTailCall to handle FIELD_LIST operands in interference checks |
Member
Author
|
/ba-g macOS-13 runner images are retired, but JIT side of the testing is covered via linux-arm64 and linux-x64 |
jakobbotsch
added
Servicing-consider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
The JIT may corrupt the values of arguments when forwarding parameters to other functions as part of a tailcall. Reported by customer in #122138.
Regression
This is a regression in .NET 10 where we started tailcalling in new scenarios not covered by some existing handling.
Testing
Regression test included.
Risk
Low. Detect the case in the existing handling and introduce additional defensive copies for it.