Skip to content

[mobile] Skip publishing tests ignored by CI #131071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 1 commit into from
Jul 21, 2026
+1 −1
Merged

[mobile] Skip publishing tests ignored by CI #131071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/testing/tests.mobile.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
<Import Project="$(MSBuildThisFileDirectory)workloads-testing.targets" Condition="'$(SkipWorkloadsTestingTargetsImport)' == 'true'" />

<Target Name="PublishTestAsSelfContained"
Condition="'$(IsCrossTargetingBuild)' != 'true'"
Condition="'$(IsCrossTargetingBuild)' != 'true' and '$(IgnoreForCI)' != 'true'"

@matouskozak matouskozak Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this caused by a specific test that was disabled recently or do you know why we started hitting this now?

@kotlarmilos kotlarmilos Jul 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is not a disabled test, System.Text.Json.SourceGeneration.Roslyn4.4.Tests has always been IgnoreForCI on mobile, so it never runs on the Apple mobile CoreCLR legs, but it was still published and trimmed

What actually fails is ILLink crashing during that publish trim with an unhandled ArgumentOutOfRangeException in Mono.Cecil.

The crash first appears in the https://dev.azure.com/dnceng-public/public/_build/results?buildId=1515988, which points to #130164 and #130665, each added a [JsonSerializable(typeof(...))] entry to the TestTypesContext source-generated context that these tests compile, which could have caused the error.

I will create a tracking issue if it doesn't exist.

@kotlarmilos kotlarmilos Jul 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #131122

@matouskozak matouskozak Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this a real issue not just a CI thing which warrant a bigger attention. Could it be something with trimmer that is broken on mobile @vitek-karas ?

@kotlarmilos kotlarmilos Jul 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a latent Cecil bug that only appears once the assembly grows past a certain size. I believe it is worth further investigation and don't think it is mobile-specific.

AfterTargets="$(PublishTestAsSelfContainedAfterTargets)"
DependsOnTargets="$(PublishTestAsSelfContainedDependsOn);$(BundleTestAppTargets);ArchiveTests" />

Expand Down
Loading