Skip to content

Add freebsd-arm64 CI#131083

Open
am11 wants to merge 1 commit into
dotnet:mainfrom
am11:patch-54
Open

Add freebsd-arm64 CI#131083
am11 wants to merge 1 commit into
dotnet:mainfrom
am11:patch-54

Conversation

@am11

@am11 am11 commented Jul 20, 2026

Copy link
Copy Markdown
Member

Build validation to prevent regressions (like #130901).

@am11

am11 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

cc @Thefrank, @sec

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jul 20, 2026
@am11
am11 temporarily deployed to copilot-pat-pool July 20, 2026 13:54 — with GitHub Actions Inactive
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@am11
am11 requested review from akoeplinger and janvorli July 20, 2026 13:54
@am11
am11 temporarily deployed to copilot-pat-pool July 20, 2026 13:54 — with GitHub Actions Inactive
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Workflow state for the Holistic Review Orchestrator.

{
  "version": 5,
  "last_dispatched_commit": "7d4d9675f085487cbab076db78f6bf376991a68a",
  "last_dispatched_base_ref": "main",
  "last_dispatched_base_sha": "af85196d561d26c2f8a0589d435cffed1c90752c",
  "last_reviewed_commit": "7d4d9675f085487cbab076db78f6bf376991a68a",
  "last_reviewed_base_ref": "main",
  "last_reviewed_base_sha": "af85196d561d26c2f8a0589d435cffed1c90752c",
  "last_recorded_worker_run_id": "29751400033",
  "review_attempt_commit": "",
  "review_attempt_base_ref": "",
  "review_attempt_count": 0,
  "max_review_attempts": 5,
  "review_history_format": "holistic-review-disclosure-v1",
  "review_history": [
    {
      "commit": "7d4d9675f085487cbab076db78f6bf376991a68a",
      "review_id": 4736063278
    }
  ]
}

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review

Motivation: The PR adds FreeBSD arm64 to the CI matrix to provide build validation that prevents regressions of the sort seen in #130901, complementing the existing FreeBSD x64 coverage.

Approach: Three coordinated pipeline edits: (1) platform-matrix.yml gains a freebsd_arm64 job block gated on containsValue(parameters.platforms, 'freebsd_arm64'), mirroring the existing freebsd_x64 block (cross build, container: freebsd_arm64, helixQueueGroup); (2) pipeline-with-resources.yml registers the freebsd_arm64 container resource pointing at the cross-freebsd-14-arm64 prereqs image with ROOTFS_DIR: /crossrootfs/arm64; (3) runtime.yml adds freebsd_arm64 to the CoreCLR+Libs+Host bootstrapped build platform list. The comment reorganization (# FreeBSD -> # FreeBSD x64 / # FreeBSD arm64, # OpenBSD -> # OpenBSD x64) is cosmetic clarification.

Summary: The change is a faithful, self-consistent extension of the established cross-BSD CI pattern. The new job block matches the freebsd_x64 template field-for-field with the correct archType/targetRid/platform/container values; the container resource uses an arm64-specific image digest and the correct ROOTFS_DIR: /crossrootfs/arm64; and the platform is wired into a rolling/PR conditional build job. No functional runtime code is touched and the risk is confined to CI. I found no correctness, security, or consistency issues. Verdict: LGTM.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 45.5 AIC · ⌖ 14.4 AIC · ⊞ 10K

@jkotas

jkotas commented Jul 20, 2026

Copy link
Copy Markdown
Member

Do we really need this? What are the changes of Arm64 FreeBSD being broken given the existing coverage?

I understand that regression can sneak through every once in a while. We live with the similar risk in number of other configurations too.

@am11

am11 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

These platforms have OS package available, so a validation leg would keep things in sync. We had two recent regressions which slipped though in #126155 and #118101.

@Thefrank

Copy link
Copy Markdown
Contributor

LGTM.
Outside of scope here: FreeBSD 15.1 is now the newest -RELEASE. We might want to move the containers off FreeBSD 14.x-RELEASE to 15.x

@sec

sec commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

LGTM. Outside of scope here: FreeBSD 15.1 is now the newest -RELEASE. We might want to move the containers off FreeBSD 14.x-RELEASE to 15.x

Doing builds under 15.x will fail - dotnet/msbuild#12944

@am11

am11 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

@jkotas, for reducing pressure on Azure DevOps, we can add GitHub Actions leg for community platform matrix. Timing wise, bootstrap builds run in parallel and complete before many other legs. If it's about not bothering people about failures of community platforms, since these breakages are rare and often easy to fix, I think it should be fine (AI can also assist in those rare cases).

@Thefrank, opened dotnet/arcade#17155. 14.4 will EOL in Dec 2026, this matrix has lowest supported version (FreeBSD 14.4 and OpenBSD 7.8 etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-arm64 area-Infrastructure community-contribution Indicates that the PR has been added by a community member os-freebsd FreeBSD OS

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants