Re-add retired r2r.yml#131100
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR reintroduces an eng/pipelines/coreclr/r2r.yml file as a stub so an existing Azure DevOps pipeline definition that still points at this path can stop warning about a missing YAML file.
Changes:
- Add a stub Azure Pipelines YAML file with
trigger: noneandpr: noneto prevent automatic runs.
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "6ca40bbb11132dfe452483809b991a5bd16f103a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "c39c3f371a1542dc1442a244bba117fb4e762299",
"last_reviewed_commit": "6ca40bbb11132dfe452483809b991a5bd16f103a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "c39c3f371a1542dc1442a244bba117fb4e762299",
"last_recorded_worker_run_id": "29772940806",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "6ca40bbb11132dfe452483809b991a5bd16f103a",
"review_id": 4738459274
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: The eng/pipelines/coreclr/r2r.yml file was previously deleted, but the corresponding Azure DevOps pipeline definition still references it, producing warnings on AzDO. Since the author lacks permission to delete the pipeline definition, adding a minimal stub file is a reasonable interim measure to silence those warnings.
Approach: The PR adds a 3-line stub r2r.yml containing an explanatory comment plus trigger: none and pr: none. These settings ensure the pipeline never runs automatically on CI or PR events, so the stub is inert and only exists to satisfy the dangling AzDO pipeline reference. A comment documents that the file should be removed once the pipeline is disabled or deleted.
Summary: This is a minimal, low-risk, well-documented workaround. trigger: none and pr: none correctly prevent any scheduled or PR-triggered runs, and the inline comment clearly captures the intent and cleanup condition. No functional or CI behavior is affected beyond suppressing the warning. I have no actionable findings.
Verdict: LGTM.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 36.7 AIC · ⌖ 15.1 AIC · ⊞ 10K
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jkoritzinsky
left a comment
There was a problem hiding this comment.
Can you ping the First Responders channel to have them delete the pipeline on the AzDO end?
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 027af8a7-5834-4205-a7c2-108a92421253
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 027af8a7-5834-4205-a7c2-108a92421253
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
eng/pipelines/coreclr/r2r.yml:1
- The PR description says this is a "dummy file" to stop AzDO warnings, but this YAML reintroduces a full (and potentially expensive) Build+Helix outerloop pipeline. Even with triggers disabled, it can still be manually queued, and it will also need to be kept in sync with template changes. At minimum, make the header comment explicit that this file exists primarily to satisfy a legacy pipeline definition and is not intended for routine use (or consider replacing it with a true no-op pipeline if that’s the only goal).
# This pipeline is a subset of crossgen2-outerloop.yml and is retained for manual runs.
The r2r.yml was deleted, but the corresponding AzDO pipeline definition wasn't deleted, and this is causing warnings on AzDO. I don't have permission to delete the definition, so we can add a dummy file in the meantime to avoid those warnings.
Demo run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1518526&view=results