Use stable names for perf sample-app binlog artifacts#131103
Merged
DrewScoggins merged 2 commits intoJul 21, 2026
Merged
Conversation
These 10 binlog artifacts are consumed downstream by the dotnet/performance runtime-perf-job.yml "Download binlog files" steps, which reference stable base names. PR dotnet#128498 classified them as diagnostic artifacts and appended _Attempt$(System.JobAttempt), breaking those cross-repo downloads. Per dotnet#128498's own naming strategy, downstream-consumed artifacts should use stable names and publish on succeeded(), matching the sibling APK uploads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the perf sample-apps pipeline template to publish MSBuild binlog artifacts using stable (non-attempt-suffixed) artifact names, and only publish them when the step is in a succeeded state.
Changes:
- Switch binlog artifact publishing from
succeededOrFailed()tosucceeded(). - Remove
_Attempt$(System.JobAttempt)suffixes from 10 binlogartifactNamevalues to restore stable names for downstream consumption.
LoopedBard3
approved these changes
Jul 20, 2026
LoopedBard3
approved these changes
Jul 20, 2026
DrewScoggins
enabled auto-merge (squash)
July 20, 2026 22:06
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 10 binlog artifacts are consumed downstream by the dotnet/performance runtime-perf-job.yml "Download binlog files" steps, which reference stable base names. PR #128498 classified them as diagnostic artifacts and appended _Attempt$(System.JobAttempt), breaking those cross-repo downloads. Per #128498's own naming strategy, downstream-consumed artifacts should use stable names and publish on succeeded(), matching the sibling APK uploads.
Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5